Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

utilities/npm: Run NPM commands via "execa" #6525

Merged
merged 3 commits into from Dec 4, 2016

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Dec 4, 2016

backport of #6503 to the beta branch

the NPM3 progress bar is screwing around with inquirer, e.g. when asking to overwrite files

essentially the question is hidden behind the progressbar and it looks as if NPM froze

/cc @rwjblue @nathanhammond @stefanpenner

@Turbo87 Turbo87 added the bug label Dec 4, 2016
@rwjblue
Copy link
Member

rwjblue commented Dec 4, 2016

@homu r+

@homu
Copy link
Contributor

homu commented Dec 4, 2016

📌 Commit ab74272 has been approved by rwjblue

@homu
Copy link
Contributor

homu commented Dec 4, 2016

⚡ Test exempted - status

@homu homu merged commit ab74272 into ember-cli:beta Dec 4, 2016
homu added a commit that referenced this pull request Dec 4, 2016
utilities/npm: Run NPM commands via "execa"

backport of #6503 to the `beta` branch

> the NPM3 progress bar is screwing around with inquirer, e.g. when asking to overwrite files
>
> essentially the question is hidden behind the progressbar and it looks as if NPM froze

/cc @rwjblue @nathanhammond @stefanpenner
@Turbo87 Turbo87 deleted the npm-via-exec branch December 4, 2016 21:12
@nathanhammond
Copy link
Contributor

Note that the intent of this is, "if it works in beta we consider promoting to release in 1-2 weeks."

homu added a commit that referenced this pull request Jan 17, 2017
Backport subprocess invocation of npm to v2.10

Backport of #6525 / #6503 for v2.10.x as discussed in #6593

Resolves #6593
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants