[BUGFIX release] Update ember-cli-htmlbars-inline-precompile requirement
#6711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ement
This fixes an error that would occur if a version <0.3.6 were installed in an app with the `ember-source` NPM package rather than the bower package, recently introduced in Ember v2.11.0:
```
$ ember s
Cannot find module 'MyApp/bower_components/ember/ember-template-compiler'
Error: Cannot find module 'MyApp/bower_components/ember/ember-template-compiler'
at Function.Module._resolveFilename (module.js:470:15)
at Function.Module._load (module.js:418:25)
at Module.require (module.js:498:17)
at require (internal/module.js:20:19)
at Class.included (MyApp/node_modules/ember-cli-htmlbars-inline-precompile/index.js:48:20)
at Class.superWrapper [as included] (MyApp/node_modules/core-object/lib/assign-properties.js:32:18)
at EmberApp.<anonymous> (MyApp/node_modules/ember-cli/lib/broccoli/ember-app.js:492:15)
at Array.filter (native)
at EmberApp._notifyAddonIncluded (MyApp/node_modules/ember-cli/lib/broccoli/ember-app.js:487:45)
at new EmberApp (MyApp/node_modules/ember-cli/lib/broccoli/ember-app.js:138:8)
```
See: https://github.com/ember-cli/ember-cli-htmlbars-inline-precompile/blob/master/CHANGELOG.md#036-2016-11-04
SaladFork
changed the title
ember-cli-htmlbars-inline-precompile requir…ember-cli-htmlbars-inline-precompile requirement
rwjblue
approved these changes
Jan 24, 2017
|
@homu r+ |
|
📌 Commit f50d04a has been approved by |
|
⚡ Test exempted - status |
homu
added a commit
that referenced
this pull request
Jan 24, 2017
[BUGFIX release] Update `ember-cli-htmlbars-inline-precompile` requirement
This fixes an error that would occur if a version <0.3.6 were installed in an app with the `ember-source` NPM package rather than the bower package, recently introduced in Ember v2.11.0:
```
$ ember s
Cannot find module 'MyApp/bower_components/ember/ember-template-compiler'
Error: Cannot find module 'MyApp/bower_components/ember/ember-template-compiler'
at Function.Module._resolveFilename (module.js:470:15)
at Function.Module._load (module.js:418:25)
at Module.require (module.js:498:17)
at require (internal/module.js:20:19)
at Class.included (MyApp/node_modules/ember-cli-htmlbars-inline-precompile/index.js:48:20)
at Class.superWrapper [as included] (MyApp/node_modules/core-object/lib/assign-properties.js:32:18)
at EmberApp.<anonymous> (MyApp/node_modules/ember-cli/lib/broccoli/ember-app.js:492:15)
at Array.filter (native)
at EmberApp._notifyAddonIncluded (MyApp/node_modules/ember-cli/lib/broccoli/ember-app.js:487:45)
at new EmberApp (MyApp/node_modules/ember-cli/lib/broccoli/ember-app.js:138:8)
```
See: https://github.com/ember-cli/ember-cli-htmlbars-inline-precompile/blob/master/CHANGELOG.md#036-2016-11-04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an error that would occur if a version <0.3.6 were installed in an app with the
ember-sourceNPM package rather than the bower package, recently introduced in Ember v2.11.0:See: https://github.com/ember-cli/ember-cli-htmlbars-inline-precompile/blob/master/CHANGELOG.md#036-2016-11-04