Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix build console output when using environment variable #6715

Merged
merged 1 commit into from Jan 25, 2017

Conversation

mike183
Copy link
Contributor

@mike183 mike183 commented Jan 25, 2017

Resolves #6642

@homu
Copy link
Contributor

homu commented Jan 25, 2017

☔ The latest upstream changes (presumably #6615) made this pull request unmergeable. Please resolve the merge conflicts.

@rwjblue
Copy link
Member

rwjblue commented Jan 25, 2017

Fixed rebase issue (and slightly tweaked the conditional). Should be good to go once Travis confirms.

Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @mike183!

@rwjblue
Copy link
Member

rwjblue commented Jan 25, 2017

@homu r+

@homu
Copy link
Contributor

homu commented Jan 25, 2017

📌 Commit d72d552 has been approved by rwjblue

@homu
Copy link
Contributor

homu commented Jan 25, 2017

⌛ Testing commit d72d552 with merge f99a226...

homu added a commit that referenced this pull request Jan 25, 2017
Fix build console output when using environment variable

Resolves #6642
@homu
Copy link
Contributor

homu commented Jan 25, 2017

💔 Test failed - status

@rwjblue
Copy link
Member

rwjblue commented Jan 25, 2017

Dangit. I've mucked this up on you @mike183. 😢

@rwjblue
Copy link
Member

rwjblue commented Jan 25, 2017

OK, I tried to fix it again (with the tried and trusty command line tools this time 😸).

@rwjblue
Copy link
Member

rwjblue commented Jan 25, 2017

@homu r+

@homu
Copy link
Contributor

homu commented Jan 25, 2017

📌 Commit da26338 has been approved by rwjblue

@homu
Copy link
Contributor

homu commented Jan 25, 2017

⌛ Testing commit da26338 with merge 0d992ff...

homu added a commit that referenced this pull request Jan 25, 2017
Fix build console output when using environment variable

Resolves #6642
@homu
Copy link
Contributor

homu commented Jan 25, 2017

☀️ Test successful - status

@homu homu merged commit da26338 into ember-cli:master Jan 25, 2017
@mike183 mike183 deleted the build-console-output-fix branch January 25, 2017 21:55
@Turbo87 Turbo87 added this to the v2.13.0 milestone Jan 26, 2017
@Turbo87 Turbo87 added the bug label Feb 23, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants