WIP: remove ember-cli-legacy-blueprints #6746
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellyselden
changed the title
|
as mentioned on Slack: this would remove the blueprints for all users that are not using ember-source yet and I don't see a reason why we would need to do that any time soon. let's revisit that if we should ever release a v3.0.0. |
|
I ran |
|
yeah, that is definitely not what we want... |
then we should debug this. https://github.com/ember-cli/ember-cli-legacy-blueprints/blob/master/package.json#L57-L60 and https://github.com/emberjs/ember.js/blob/master/package.json#L92 look correct to me |
|
I've opened #6751 to track this issue |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
now that ember-source provides our blueprints