Remove "proxyquire" dependency #6797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
Feb 21, 2017
| return mergeTreesStub.apply(this, arguments); | ||
| }, | ||
| }); | ||
| let mergeTrees = require('../../../lib/broccoli/merge-trees') |
There was a problem hiding this comment.
missing semi-colon, also we generally use const for required things...
|
☔ The latest upstream changes (presumably #6729) made this pull request unmergeable. Please resolve the merge conflicts. |
|
@rwjblue fixed the failing tests. should be ready now. |
|
The addition of underscored member functions is what I was trying to avoid when adding this. That said, I'm not necessarily against this. |
stefanpenner
approved these changes
Feb 21, 2017
|
@homu r+ |
|
📌 Commit fbb5985 has been approved by |
homu
added a commit
that referenced
this pull request
Feb 21, 2017
Remove "proxyquire" dependency `proxyquire` is hard to use and understand and we can do much better with a much simpler API in many cases
|
☀️ Test successful - status |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
proxyquireis hard to use and understand and we can do much better with a much simpler API in many cases