Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX beta] Don't generate addon-config/targets.js in addons #6861

Merged
merged 1 commit into from Mar 16, 2017
Merged

[BUGFIX beta] Don't generate addon-config/targets.js in addons #6861

merged 1 commit into from Mar 16, 2017

Conversation

cibernox
Copy link
Contributor

No description provided.

@rwjblue
Copy link
Member

rwjblue commented Mar 16, 2017

@cibernox - Can you change the PR to target the beta branch?

@cibernox cibernox changed the base branch from master to beta March 16, 2017 14:12
@cibernox
Copy link
Contributor Author

@rwjblue done

rwjblue
rwjblue approved these changes Mar 16, 2017
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing @cibernox!

Note to others, we will have to merge manually (homu doesn't handle changing the target branch).

@rwjblue rwjblue merged commit 964bb0f into ember-cli:beta Mar 16, 2017
@Turbo87 Turbo87 added the bug label Mar 21, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cibernox @rwjblue @Turbo87