Fix generate command when both usePods option and --pod argument is used

[emrekutlu]

Resolves #7163

[rwjblue]

I agree that this is confusing, but the intent here was that --pod flag negates the value of usePods. So if you had usePods as true you would use --pod to get non-pods.

[emrekutlu]

Hmm, so what does --classic do?

[Turbo87]

@rwjblue I tend to agree with this patch. Having --pod disable pod style when --classic also exists seems very unintuitive.

[rwjblue]

@Turbo87 - This patch has nothing to do with using both --pod and --classic at the same time, what am I missing?

[hjdivad]

@Turbo87 - This patch has nothing to do with using both --pod and --classic at the same time, what am I missing?

I think the point is that the existence of --classic implies the semantics of --pod is --use-pods and not --toggle-pods and not (only) that they're confusing when used together

[rwjblue]

I totally agree with you there, but this change would be a breaking change for anyone leveraging the existing behavior.

I'd be totally fine with adding a deprecation / warning for anyone that has both usePods and specifies either --pods or --classic specified, but not with arbitrarily changing the meaning of the flags (at least not within the same release, but it could be feathered out)...

[Turbo87]

@emrekutlu can you prepare a PR that prints a warning to the console when --pod is used in combination with usePods?

[rwjblue]

@emrekutlu - Ping?

[emrekutlu]

@rwjblue sorry for the wait, I am going to update the pull request this week hopefully. Thanks for pinging.

[emrekutlu]

@rwjblue I updated the pull request.

[rwjblue]

Thank you!