Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

preserve final newline in addon's package.json #7364

Merged
merged 1 commit into from Oct 8, 2017
Merged

preserve final newline in addon's package.json #7364

merged 1 commit into from Oct 8, 2017

Conversation

kellyselden
Copy link
Member

@Turbo87
Copy link
Member

Turbo87 commented Oct 8, 2017

@kellyselden should this target beta?

@Turbo87 Turbo87 added the bug label Oct 8, 2017
@kellyselden
Copy link
Member Author

I couldn't remember if I should cherry-pick into beta.

@Turbo87
Copy link
Member

Turbo87 commented Oct 8, 2017

nope, just target beta directly, otherwise things will be forgotten 😉

@kellyselden kellyselden changed the base branch from master to beta October 8, 2017 17:10
@kellyselden
Copy link
Member Author

retargeted and ready for merge

@rwjblue rwjblue merged commit 75e74c8 into ember-cli:beta Oct 8, 2017
@kellyselden kellyselden deleted the append-package-json-newline branch October 8, 2017 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kellyselden @Turbo87 @rwjblue