Allows users to disableDependencyChecker from .ember-cli options.
#7413
Conversation
Right now we need to pass this option via the constructor, which is used for tests, but as a user I don't have a way to disable this. There are reasons to disable this outside of tests: * The DependencyChecker doesn't work today with yarn workspaces * We may be using a different way to check dependencies like yarn --check-integrity
|
You should either remove the addon or disable it via the SKIP_DEPENDENCY_CHECKER environment variable. Most likely the former if you are trying to always skip it... |
|
Both of the bullets mentioned here infer that you just don’t need the addon. Removing it (just like any other addon) is a perfectly viable option and seems much more inline with what your actual intentions are here... |
|
That sounds like a good option. But I'm not sure what addon you're referring to. I don't have ember-cli-dependency-checker installed. Not sure if that's the addon you're referring to. The problem seems to be on Project#hasDependency https://github.com/ember-cli/ember-cli/blob/mmadero/disableDependencyChecker-support/lib/models/project.js#130 |
|
Looks like there is a separate bug introduced on #7401 I'll leave this open since it might make sense on its own |
|
I fixed it on #7414 |
|
@rwjblue ping! |
|
sounds like this is mostly resolved now :) |
|
👍 |
Right now we need to pass this option via the constructor,
which is used for tests, but as a user I don't have a way to disable this.
There are reasons to disable this outside of tests: