-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add osx testing #7440
add osx testing #7440
Conversation
I would consider adding it because:
do we know what the slow down would be? |
Travis CI doesn't have that many divvied up for OSS project use I believe. You get placed in a queue during peak business hours. Maybe they would donate priority status for us? |
I'd be okay with occasionally running CI on OSX, but doing it for every PR seems unnecessary if it increases the time until CI is green by such a large amount. The differences between OSX and Linux are rather small so I don't think it's currently worth it. |
We decided that blocking PRs until an OSX box is allocated is not worth it. We are going to try running this only on master instead. |
0f19541
to
d52e9e2
Compare
I couldn't figure out how to exclude PRs. It's just running allow failure now. |
Ya, I think this is the one configuration that I really dislike 😜 (allowed failure).... |
Yea, at this point we can keep or decline. I will leave it up to someone else to make the call. |
I don't see much practical value in this at this point. I'd vote for closing this for now and if OSX testing on Travis gets faster at some point we can revisit. |
Agreed. Thanks for working on this though @kellyselden! |
This is mainly for discussion. It is possible to test in OSX. The jobs tend to take a while to be allocated, so it would slow down our CI (as well as adding the additional job(s)).
Is this worth it? Do we ever regress in mac while Windows and Linux are fine?
cc @ember-cli/core