Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add osx testing #7440

Closed
wants to merge 1 commit into from
Closed

add osx testing #7440

wants to merge 1 commit into from

Conversation

kellyselden
Copy link
Member

This is mainly for discussion. It is possible to test in OSX. The jobs tend to take a while to be allocated, so it would slow down our CI (as well as adding the additional job(s)).

Is this worth it? Do we ever regress in mac while Windows and Linux are fine?

cc @ember-cli/core

@twokul
Copy link
Contributor

twokul commented Nov 12, 2017

Is this worth it? Do we ever regress in mac while Windows and Linux are fine?

I would consider adding it because:

  • majority of developers use mac
  • new features like AFS (Apple File System) in High Sierra might be useful to test before releasing to users (I've been running Ember CLI on High Sierra for a while now and haven't seen major regressions).

The jobs tend to take a while to be allocated, so it would slow down our CI

do we know what the slow down would be?

@kellyselden
Copy link
Member Author

do we know what the slow down would be?

Travis CI doesn't have that many divvied up for OSS project use I believe. You get placed in a queue during peak business hours.

Maybe they would donate priority status for us?

@Turbo87
Copy link
Member

Turbo87 commented Nov 12, 2017

I'd be okay with occasionally running CI on OSX, but doing it for every PR seems unnecessary if it increases the time until CI is green by such a large amount. The differences between OSX and Linux are rather small so I don't think it's currently worth it.

@kellyselden
Copy link
Member Author

We decided that blocking PRs until an OSX box is allocated is not worth it. We are going to try running this only on master instead.

@kellyselden
Copy link
Member Author

I couldn't figure out how to exclude PRs. It's just running allow failure now.

@rwjblue
Copy link
Member

rwjblue commented Nov 16, 2017

Ya, I think this is the one configuration that I really dislike 😜 (allowed failure)....

@kellyselden
Copy link
Member Author

Yea, at this point we can keep or decline. I will leave it up to someone else to make the call.

@Turbo87
Copy link
Member

Turbo87 commented Nov 20, 2017

I don't see much practical value in this at this point. I'd vote for closing this for now and if OSX testing on Travis gets faster at some point we can revisit.

@rwjblue
Copy link
Member

rwjblue commented Nov 20, 2017

Agreed. Thanks for working on this though @kellyselden!

@rwjblue rwjblue closed this Nov 20, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants