Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Continue to use jQuery in Ember 2.x scenarios #8005

Conversation

cibernox
Copy link
Contributor

It turns out the default blueprint for addons generates an addon whose 2.X scenarios in ember-try fail by default.

In ca68ba3#diff-d2dc84345b41f0668236a56410bcc7bc addons began to be tested without jQuery by default, which is great, but in Ember 2.X we also need to install the ember-native-dom-event-dispatcher.

I still suspect this may not help the tests for Ember 2.12, but let's start from here.

@cibernox cibernox force-pushed the fix-addon-tests-in-2.x-scenarions-in-ember-try branch 2 times, most recently from 54ac329 to 10a9536 Compare August 31, 2018 13:15
@rwjblue rwjblue changed the title [BUGFIX] Add ember-native-dom-event-dispatcher to 2.X ember-try scenarios by default [BUGFIX] Continue to use jQuery in Ember 2.x scenarios Aug 31, 2018
@cibernox cibernox force-pushed the fix-addon-tests-in-2.x-scenarions-in-ember-try branch from 10a9536 to bf25b43 Compare August 31, 2018 13:46
@rwjblue
Copy link
Member

rwjblue commented Aug 31, 2018

This is looking good, I'd like to get this targetted at beta branch (which will require you to update the PR target and drop out any additional commits that are on master where you forked from and beta).

Also, can you confirm if we do or do not need to also add @ember/jquery to each of these 2.x scenarios? It seems to me that we should have it in there, but I just wanting to make sure we don't emit warnings about it during these try scenarios...

@cibernox cibernox force-pushed the fix-addon-tests-in-2.x-scenarions-in-ember-try branch from bf25b43 to f404146 Compare August 31, 2018 13:58
@cibernox cibernox changed the base branch from master to beta August 31, 2018 13:58
@cibernox cibernox force-pushed the fix-addon-tests-in-2.x-scenarions-in-ember-try branch from f404146 to 0e28de7 Compare August 31, 2018 14:01
@cibernox
Copy link
Contributor Author

@rwjblue I added the @ember/jquery addon to those scenarios to silence the warning (although I think it would work anyway).

Rebased over beta.

@rwjblue rwjblue merged commit 1f0d49f into ember-cli:beta Aug 31, 2018
@cibernox cibernox deleted the fix-addon-tests-in-2.x-scenarions-in-ember-try branch August 31, 2018 14:56
@cibernox cibernox restored the fix-addon-tests-in-2.x-scenarions-in-ember-try branch August 31, 2018 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants