BUGFIX: Clear project.configCache before starting the build #8819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes please! |
|
@colenso - Would you mind adding some tests here so that we don't regress again? |
|
Still needs some tests... |
|
@colenso I tried rebasing but I don't think I have access! Do you have some cycles to rebase and submit the test? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8478
The problem I noticed was that
get-serve-urlwould accessproject.configafterfinalizeBuildand hence the config would get cached and would be used in the next build. Hence each build was using the previous build's config.This PR simply clears the
project.configCachebefore the build is started.