Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Remove deprecated exp. from ALL_EXPERIMENTS #8830

Merged
merged 1 commit into from
Sep 7, 2019
Merged

CI: Remove deprecated exp. from ALL_EXPERIMENTS #8830

merged 1 commit into from
Sep 7, 2019

Conversation

dcyriller
Copy link
Contributor

@dcyriller dcyriller commented Sep 6, 2019

Disable MODULE_UNIFICATION experiment for EMBER_CLI_ALL_EXPERIMENTS CI job.

With #8827 I've set some acceptance tests behind the following conditional:

   if (!isExperimentEnabled('MODULE_UNIFICATION')) {
    it(
      'addons with standard preprocessors compile correctly',
      co.wrap(function*() {
        ...
      })
    );
  }

That PR would disable some acceptance tests for EMBER_CLI_ALL_EXPERIMENTS test scenario. This PR aims at fixing that.

@rwjblue rwjblue merged commit 2959aef into ember-cli:master Sep 7, 2019
@dcyriller dcyriller deleted the ci-adjust-all-experiments branch September 8, 2019 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants