Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace addon testing ember 3.4 for 3.12 #8946

Merged
merged 1 commit into from
Nov 29, 2019

Conversation

kellyselden
Copy link
Member

We are overdue for another bump in latest 2 ember LTS for addon testing support. This swaps 3.4 for 3.12.

@kellyselden kellyselden merged commit 65d4e41 into ember-cli:release Nov 29, 2019
@kellyselden kellyselden deleted the drop_addon_3.4 branch November 29, 2019 19:14
@Turbo87
Copy link
Member

Turbo87 commented Dec 1, 2019

@kellyselden why did you target release with this? seems like this will be a breaking change for most addons that adopt this change 🤔

@kellyselden
Copy link
Member Author

We've always been shifting the last 2 LTS's in the blueprints. We actually should have done this in ember-cli 3.13's stable release when 3.12 became LTS, I just forgot. As with most our blueprint changes, addon's have a choice whether they want to track these changes and adjust their major version accordingly. Do you have concerns with this policy?

@Turbo87
Copy link
Member

Turbo87 commented Dec 1, 2019

problem is just that if we release this in a patch version bump we have no way of communicating this change in the release blog post since we only do those for minor and major version releases

@kellyselden
Copy link
Member Author

That's a good point. I forgot about release blog post.

@knownasilya
Copy link
Contributor

knownasilya commented Dec 2, 2019

Maybe do a blog post any way 🤷‍♂

@rwjblue
Copy link
Member

rwjblue commented Dec 3, 2019

Tweaking this to target beta (I don't think its great to land a breaking change patch release of 3.14) (basically reverting from release and reverting the revert from beta).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants