Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use GitHub Actions for CI #8949

Merged
merged 1 commit into from Dec 12, 2019
Merged

Use GitHub Actions for CI #8949

merged 1 commit into from Dec 12, 2019

Conversation

Turbo87
Copy link
Member

@Turbo87 Turbo87 commented Dec 1, 2019

because it's usually much faster and supports Windows too

@kellyselden
Copy link
Member

Is there a chance we'll run out of free minutes on the OSS plan?

@Turbo87
Copy link
Member Author

Turbo87 commented Dec 1, 2019

@kellyselden AFAIK they changed the policy and there is no limit anymore for public projects

@Turbo87 Turbo87 changed the base branch from master to release December 1, 2019 18:41
@kellyselden
Copy link
Member

Looks successful. Do they allow stages for our linting and unit check?

@Turbo87
Copy link
Member Author

Turbo87 commented Dec 2, 2019

Do they allow stages for our linting and unit check?

sort of. it's modeled as a graph, so for example later stage jobs care declare what previous jobs need to have run first using needs.

@rwjblue
Copy link
Member

rwjblue commented Dec 11, 2019

@Turbo87 - What is still pending here?

@Turbo87
Copy link
Member Author

Turbo87 commented Dec 11, 2019

@rwjblue nothing... 😅

Windows tests are not working yet for various reasons, but we can tackle that in a dedicated PR

@Turbo87 Turbo87 changed the title WIP: Use GitHub Actions for CI Use GitHub Actions for CI Dec 11, 2019
@rwjblue rwjblue merged commit a05d5c2 into release Dec 12, 2019
@rwjblue rwjblue deleted the actions branch December 12, 2019 18:08
@rwjblue
Copy link
Member

rwjblue commented Dec 12, 2019

This just adds GH actions, we can reevaluate usage of Travis and AppVeyor as we gain confidence here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants