Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Update .npmignore to ignore .github and docs folders #9700

Merged
merged 2 commits into from Dec 13, 2021
Merged

[Chore] Update .npmignore to ignore .github and docs folders #9700

merged 2 commits into from Dec 13, 2021

Conversation

SergeAstapov
Copy link
Contributor

Currently, running npm pack --dry-run --json | grep "github\|docs" returns long list with lots of files in /docs folder and everything under .github.

Tarball Details:

npm notice name:          ember-cli                               
npm notice version:       4.0.0-beta.2                            
npm notice filename:      ember-cli-4.0.0-beta.2.tgz              
npm notice package size:  531.9 kB                                
npm notice unpacked size: 2.8 MB

After the change, running npm pack --dry-run --json | grep "github\|docs" returns:

"path": "docs/build/data.json",
"path": ".github/workflows/ci.yml",
"path": "blueprints/addon/files/.github/workflows/ci.yml",
"path": "blueprints/app/files/.github/workflows/ci.yml",

With Tarball Details:

npm notice name:          ember-cli                               
npm notice version:       4.0.0-beta.2                            
npm notice filename:      ember-cli-4.0.0-beta.2.tgz              
npm notice package size:  259.4 kB                                
npm notice unpacked size: 1.2 MB

Problem is that !docs/build/data.json "kill" the /docs/ rule and we need to explicitly ignore files within that dir.

@rwjblue rwjblue merged commit 59719e2 into ember-cli:master Dec 13, 2021
@SergeAstapov SergeAstapov deleted the update-npmignore branch December 13, 2021 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants