fetch is not defined - maybe your browser targets are not covering everything you need #547

cah-brian-gantzler · 2020-08-08T00:45:46Z

I believe I have tracked the issue down to https://github.com/github/fetch. In version 3.1.1 it used to contain this https://github.com/github/fetch/blob/v3.1.1/fetch.js#L546 but in 3.2.0 it now contains this https://github.com/github/fetch/blob/v3.2.0/fetch.js#L564

Ember-fetch contains this check https://github.com/ember-cli/ember-fetch/blob/master/assets/browser-fetch.js.t#L36. I believe the module body here https://github.com/ember-cli/ember-fetch/blob/master/assets/browser-fetch.js.t#L34 injects the fetch library somehow. Ember-fetch is checking self and I think it now needs to check global maybe. Since this happened so long ago I dont know what dependencies have changed to make it fail for me now, but it failed today for me in multiple unrelated projects.

The text was updated successfully, but these errors were encountered:

mrloop · 2020-08-08T10:34:56Z

If your using yarn add this to your package.json

"resolutions": {
  "whatwg-fetch": "3.3.1"
 }

Looks like new release 3.4.0 of whatwg-fetch breaks ember-fetch

rwjblue · 2020-08-08T13:04:31Z

Hmm, maybe this global:

ember-fetch/assets/browser-fetch.js.t

Line 1 in 612bfd0

(function (global) {

Is now conflicting with this?

https://github.com/github/fetch/blob/99b26818147a4288429fcd96421cf038dccbc1ac/fetch.js#L1-L4

rwjblue · 2020-08-08T13:06:28Z

I did try to see if the tests here would fail with the latest versions of whatwg-fetch, and they do not (#548).

Does anyone have a reproduction?

RobbieTheWagner · 2020-08-08T15:14:44Z

All of my addons have started failing with Error: fetch is not defined - maybe your browser targets are not covering everything you need?. What's the workaround?

RobbieTheWagner · 2020-08-08T15:16:45Z

This addon docs PR is currently throwing the error ember-learn/ember-cli-addon-docs#495

RobbieTheWagner · 2020-08-08T15:25:51Z

I can confirm adding this fixes the issue for addon docs:

"resolutions": {
  "whatwg-fetch": "3.3.1"
 }

Is there a fix we can add to ember-fetch so this is not necessary?

rwjblue · 2020-08-08T15:27:26Z

Is there a fix we can add to ember-fetch so this is not necessary?

Definitely. Once we know what is actually wrong 😃

We need a repro, and ideally to make this addons test suite fail like what is happening for realz...

cah-brian-gantzler · 2020-08-08T15:34:40Z

https://github.com/bgantzler/fetch-app

Just a new application, install ember-fetch, create a controller and import fetch. Will fail when you run the app

cah-brian-gantzler · 2020-08-08T15:36:04Z

fails when you run the tests. They are the default blueprint tests unmodified

cah-brian-gantzler · 2020-08-08T15:38:39Z

Oh and I resolved to the failing version using

"resolutions": {
  "whatwg-fetch": "3.4.0"
 }

just in case cause I saw a merge of a yarn.lock rollback

rwjblue · 2020-08-08T18:34:10Z

Just a new application, install ember-fetch, create a controller and import fetch. Will fail when you run the app

Hmm, why aren't our own tests failing here then (if that is all that is needed)?

See ember-cli/ember-fetch#547

RobbieTheWagner · 2020-08-09T16:12:07Z

Just a new application, install ember-fetch, create a controller and import fetch. Will fail when you run the app

Hmm, why aren't our own tests failing here then (if that is all that is needed)?

@rwjblue perhaps importing fetch in tests does not do the same things as importing it in app code?

RobbieTheWagner · 2020-08-09T16:14:26Z

Perhaps we should set this addon to explicitly use 3.3.1 until we have a fix?

cah-brian-gantzler · 2020-08-09T16:22:03Z

For the simple app I have created above, running the test ember t does fail on the controller

not ok 1 Chrome 84.0 - [145 ms] - Unit | Controller | application: it exists
    ---
        actual: >
            null
        stack: >
            Error: fetch is not defined - maybe your browser targets are not covering everything you need?
                at Module.callback (http://localhost:7357/assets/vendor.js:66720:13)
                at Module.exports (http://localhost:7357/assets/vendor.js:118:32)
                at Module._reify (http://localhost:7357/assets/vendor.js:155:59)
                at Module.reify (http://localhost:7357/assets/vendor.js:142:27)
                at Module.exports (http://localhost:7357/assets/vendor.js:116:10)
                at requireModule (http://localhost:7357/assets/vendor.js:39:18)
                at Class._extractDefaultExport (http://localhost:7357/assets/vendor.js:92885:20)
                at Class.resolveOther (http://localhost:7357/assets/vendor.js:92545:32)
                at Class.resolve (http://localhost:7357/assets/vendor.js:92608:25)
                at resolve (http://localhost:7357/assets/vendor.js:1884:36)
        message: >
            Died on test #1     at Object.<anonymous> (http://localhost:7357/assets/tests.js:15:21)
                at processModule (http://localhost:7357/assets/test-support.js:3894:16)
                at module$1 (http://localhost:7357/assets/test-support.js:3919:4)
                at Module.callback (http://localhost:7357/assets/tests.js:12:21)
                at Module.exports (http://localhost:7357/assets/vendor.js:118:32)
                at requireModule (http://localhost:7357/assets/vendor.js:39:18)
                at TestLoader.require (http://localhost:7357/assets/test-support.js:14364:9)
                at TestLoader.loadModules (http://localhost:7357/assets/test-support.js:14357:14): fetch is not defined - maybe your browser targets are not covering everything you need?
        negative: >
            false
        browser log: |
    ...
ok 2 Chrome 84.0 - [1 ms] - ember-qunit: Ember.onerror validation: Ember.onerror is functioning properly

1..2
# tests 2
# pass  1
# skip  0
# todo  0
# fail  1

cah-brian-gantzler · 2020-08-09T16:24:11Z

Oh im sorry. I think I know what you mean. You mean ONLY importing fetch in tests. Yes I believe you may be correct. If has something to do with the loader.

This is the initial post I made in discord help

Uncaught Error: fetch is not defined - maybe your browser targets are not covering everything you need?
    at Module.callback (ember-fetch.js:824)
    at Module.exports (loader.js:106)
    at Module._reify (loader.js:143)
    at Module.reify (loader.js:130)
    at Module.exports (loader.js:104)
    at Module._reify (loader.js:143)
    at Module.reify (loader.js:130)
    at Module.exports (loader.js:104)
    at requireModule (loader.js:27)
    at Class._extractDefaultExport (index.js:397)

cah-brian-gantzler · 2020-08-09T16:36:54Z

I dont know if this helps, but on the repo I posted https://github.com/bgantzler/fetch-app if you switch to the branch acceptance (I just created), the fetch is no longer in the app, so the app no longer fails. It is now only imported in an acceptance test. And it fails there.

RobbieTheWagner · 2020-08-09T16:38:27Z

Hmm, I have no idea why it doesn't fail in tests in this repo then. I think we should likely set to 3.3.1 explicitly until someone can figure out the real fix. @rwjblue thoughts on putting that in as a temporary patch?

cah-brian-gantzler · 2020-08-09T16:52:55Z

During this addons test run, the ember-fetch in vendor doesnt have any code where the <%= moduleBody %> is suppose to be

When when I run during my apps controller test (master) there is

So yea, the test environments they are running in are different

chancancode · 2020-08-09T21:27:37Z

The tutorial builds are failing as well: https://github.com/ember-learn/super-rentals-tutorial/actions/runs/199896721

xg-wang · 2020-08-09T21:34:30Z

Created a PR for failing CI.
It seems the self -> global name change Rob mentioned broke ember-fetch

RobbieTheWagner · 2020-08-10T00:09:24Z

Nice, thanks @xg-wang! Looking forward to having this merged 😃

xg-wang · 2020-08-10T00:58:29Z

@rwwagner90 no problem! Just released https://www.npmjs.com/package/ember-fetch/v/8.0.2

chancancode · 2020-08-10T05:07:40Z

Tutorial build is fixed with #552 https://github.com/ember-learn/super-rentals-tutorial/actions/runs/201815359

Also drop un-used XHR mocking dependencies, and pin a dependency of ember-cli-addon-docs per ember-cli/ember-fetch#547 (which could alternatively be resolved by upgrading ember-cli-addon-docs to ^8.0.2)

EugeniaZhang · 2020-08-11T06:16:49Z

"resolutions": {
"whatwg-fetch": "3.4.0"
}
I use this did not resolved the question

RobbieTheWagner · 2020-08-11T11:18:26Z

@EugeniaZhang that would not resolve the issue, as 3.4.0 is where the issue began. You would need:

"resolutions": {
  "whatwg-fetch": "3.3.1"
 }

However, version 8.0.2 of ember-fetch has a fix for this issue, so I would recommend updating to 8.0.2.

iamareebjamal · 2020-08-12T06:27:52Z

Failing for 8.0.2 as well https://github.com/fossasia/open-event-frontend/pull/4732/files https://travis-ci.com/github/fossasia/open-event-frontend/builds/179380414

RobbieTheWagner · 2020-08-12T11:06:23Z

@iamareebjamal maybe try yarn upgrade? If it's failing, something is likely still not using 8.0.2.

Pin whatwg-fetch dependence to '3.3.1'. This fixes an error "fetch is not defined - maybe your browser targets are not covering everything you need?" that shows up when running the tests for the floating dependencies stage. That error comes from ember-fetch, see ember-cli/ember-fetch#547 Also remove unused ember-ajax and ember-fetch devDependencies

Pin whatwg-fetch dependence to '3.3.1'. This fixes an error "fetch is not defined - maybe your browser targets are not covering everything you need?" that shows up when running the tests for the floating dependencies stage. That error comes from ember-fetch, see ember-cli/ember-fetch#547

Also drop un-used XHR mocking dependencies, and pin a dependency of ember-cli-addon-docs per ember-cli/ember-fetch#547 (which could alternatively be resolved by upgrading ember-cli-addon-docs to ^8.0.2)

This was fixed in ember-fetch@8.0.2 but we are stuck using ember-fetch@6 (due to Node version compat). This works around the issue. See ember-cli/ember-fetch#547 for more details.

ember-data: Too permissive. The latest version 3.26 was being installed. Incompatible with the existing setup whatwg-fetch: Incompatible version. Should be cleared up when we next upgrade addon-docs. (ember-cli/ember-fetch#547)

…431) As sub-dependencies out in the wild have been updated they have caused the "Floating Dependencies" builds to fail. ember-data: Too permissive. The latest version 3.26 was being installed. Incompatible with the existing addon whatwg-fetch: Incompatible version. Can be cleared up when we next upgrade addon-docs. (ember-cli/ember-fetch#547)

tehmaestro · 2021-04-20T08:48:22Z

I'm using ember-fetch 8.0.4 and still have this issue.

xg-wang · 2021-04-20T15:40:40Z

@tehmaestro can you paste the output of yarn why whatwg-fetch to tell us what's the versions you're using?

allthesignals · 2021-04-20T18:49:50Z

@tehmaestro can you paste the output of yarn why whatwg-fetch to tell us what's the versions you're using?

yarn why whatwg-fetch
yarn why v1.22.4
[1/4] 🤔 Why do we have the module "whatwg-fetch"...?
[2/4] 🚚 Initialising dependency graph...
[3/4] 🔍 Finding dependency...
[4/4] 🚡 Calculating file sizes...
=> Found "whatwg-fetch@3.6.2"
info Reasons this module exists

"pretender" depends on it
Hoisted from "pretender#whatwg-fetch"
Hoisted from "ember-fetch#whatwg-fetch"
Hoisted from "ember-simple-auth#ember-fetch#whatwg-fetch"
Hoisted from "ember-simple-auth-token#ember-fetch#whatwg-fetch"
info Disk size without dependencies: "72KB"
info Disk size with unique dependencies: "72KB"
info Disk size with transitive dependencies: "72KB"
info Number of shared dependencies: 0
✨ Done in 0.87s.

tehmaestro · 2021-04-20T19:30:35Z

Hey, turns out I was using ember-simple-auth version 2.1.0, which uses an older version of ember-fetch . I was able to fix the issue by upgrading ember-simple-auth

Known issue breaks app but can be resolved by upgrading: ember-cli/ember-fetch#547

rwjblue mentioned this issue Aug 8, 2020

Re-roll yarn.lock file. #548

Merged

erikap added a commit to lblod/frontend-loket that referenced this issue Aug 8, 2020

Set fixed version for whatwg-fetch

51f4374

See ember-cli/ember-fetch#547

Turbo87 mentioned this issue Aug 9, 2020

Lock file maintenance skylines-project/skylines#2123

Merged

1 task

xg-wang mentioned this issue Aug 9, 2020

test: test both preferNative true & false in ci #551

Closed

xg-wang mentioned this issue Aug 9, 2020

Fix whatwg-fetch 3.4 global object name change compatibility #552

Merged

xg-wang closed this as completed in #552 Aug 10, 2020

mixonic mentioned this issue Aug 10, 2020

3.0: Drop support for Ember pre-2.4 Addepar/ember-table#830

Merged

ijlee2 mentioned this issue Aug 10, 2020

Updated development dependencies to their latest ember-learn/ember-octane-vs-classic-cheat-sheet#56

Merged

manurampandit mentioned this issue Oct 18, 2020

Fixed three eslint issues - ember-learn/ember-website#678

Merged

bantic mentioned this issue Nov 2, 2020

[tests] Fix "Floating Dependencies" tests Addepar/ember-table#841

Closed

cah-brian-gantzler mentioned this issue Nov 11, 2020

Releasing a version of ember-cli-mirage miragejs/ember-cli-mirage#2055

Closed

backspace mentioned this issue Jan 29, 2021

UI: Update ember-a11y-testing hashicorp/nomad#9912

Merged

Sticksword mentioned this issue Mar 29, 2021

Upgrade ember-fetch to clear failing tests nypublicradio/nypr-design-system#190

Open

gilest mentioned this issue Apr 17, 2021

Pin incompatible dependencies adopted-ember-addons/ember-file-upload#431

Merged

allthesignals mentioned this issue May 3, 2021

Page does hard refresh when session invalidated fenichelar/ember-simple-auth-token#261

Closed

aatauil added a commit to lblod/frontend-dashboard that referenced this issue Jun 7, 2021

Upgrade ember-fetch & ember-simple-auth (see description)

c02a6c0

Known issue breaks app but can be resolved by upgrading: ember-cli/ember-fetch#547

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fetch is not defined - maybe your browser targets are not covering everything you need #547

fetch is not defined - maybe your browser targets are not covering everything you need #547

cah-brian-gantzler commented Aug 8, 2020 •

edited

mrloop commented Aug 8, 2020

rwjblue commented Aug 8, 2020

rwjblue commented Aug 8, 2020

RobbieTheWagner commented Aug 8, 2020

RobbieTheWagner commented Aug 8, 2020

RobbieTheWagner commented Aug 8, 2020

rwjblue commented Aug 8, 2020

cah-brian-gantzler commented Aug 8, 2020

cah-brian-gantzler commented Aug 8, 2020

cah-brian-gantzler commented Aug 8, 2020

rwjblue commented Aug 8, 2020

RobbieTheWagner commented Aug 9, 2020

RobbieTheWagner commented Aug 9, 2020

cah-brian-gantzler commented Aug 9, 2020

cah-brian-gantzler commented Aug 9, 2020

cah-brian-gantzler commented Aug 9, 2020 •

edited

RobbieTheWagner commented Aug 9, 2020

cah-brian-gantzler commented Aug 9, 2020 •

edited

chancancode commented Aug 9, 2020

xg-wang commented Aug 9, 2020

RobbieTheWagner commented Aug 10, 2020

xg-wang commented Aug 10, 2020

chancancode commented Aug 10, 2020

EugeniaZhang commented Aug 11, 2020

RobbieTheWagner commented Aug 11, 2020

iamareebjamal commented Aug 12, 2020

RobbieTheWagner commented Aug 12, 2020

tehmaestro commented Apr 20, 2021

xg-wang commented Apr 20, 2021

allthesignals commented Apr 20, 2021

tehmaestro commented Apr 20, 2021

fetch is not defined - maybe your browser targets are not covering everything you need #547

fetch is not defined - maybe your browser targets are not covering everything you need #547

Comments

cah-brian-gantzler commented Aug 8, 2020 • edited

mrloop commented Aug 8, 2020

rwjblue commented Aug 8, 2020

rwjblue commented Aug 8, 2020

RobbieTheWagner commented Aug 8, 2020

RobbieTheWagner commented Aug 8, 2020

RobbieTheWagner commented Aug 8, 2020

rwjblue commented Aug 8, 2020

cah-brian-gantzler commented Aug 8, 2020

cah-brian-gantzler commented Aug 8, 2020

cah-brian-gantzler commented Aug 8, 2020

rwjblue commented Aug 8, 2020

RobbieTheWagner commented Aug 9, 2020

RobbieTheWagner commented Aug 9, 2020

cah-brian-gantzler commented Aug 9, 2020

cah-brian-gantzler commented Aug 9, 2020

cah-brian-gantzler commented Aug 9, 2020 • edited

RobbieTheWagner commented Aug 9, 2020

cah-brian-gantzler commented Aug 9, 2020 • edited

chancancode commented Aug 9, 2020

xg-wang commented Aug 9, 2020

RobbieTheWagner commented Aug 10, 2020

xg-wang commented Aug 10, 2020

chancancode commented Aug 10, 2020

EugeniaZhang commented Aug 11, 2020

RobbieTheWagner commented Aug 11, 2020

iamareebjamal commented Aug 12, 2020

RobbieTheWagner commented Aug 12, 2020

tehmaestro commented Apr 20, 2021

xg-wang commented Apr 20, 2021

allthesignals commented Apr 20, 2021

tehmaestro commented Apr 20, 2021

cah-brian-gantzler commented Aug 8, 2020 •

edited

cah-brian-gantzler commented Aug 9, 2020 •

edited

cah-brian-gantzler commented Aug 9, 2020 •

edited