Bump deps, drop node 6 #348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xg-wang
force-pushed
the
breaking-deps
branch
2 times, most recently
from
fe0cc25
to
bedab4e
Compare
|
Seems good to me, do we need to be worried about multiple major versions in play within the app at once anymore? |
|
@rwjblue I'm hoping to get #292 in, then any fastboot app should be safe. For multiple major in browser only app it's no different than other addons. Unfortunately there's no perfect solution now. The best way for app to guard is to install https://github.com/salsify/ember-cli-dependency-lint. For addon authors if the addon depends on a specific version |
xg-wang
force-pushed
the
breaking-deps
branch
from
bedab4e
to
01c0731
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.