Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable absolute url transform for Request in FastBoot #358

Merged
merged 2 commits into from
Sep 12, 2019

Conversation

xg-wang
Copy link
Member

@xg-wang xg-wang commented Sep 11, 2019

Overrides #356, fixes #355.

The problem is that node-fetch parses input argument in Request's constructor, so any changes made after that are not taken into account, and the request fails with Only absolute URLs are supported error.
Also, the url property is marked as read-only https://developer.mozilla.org/en-US/docs/Web/API/Request/url, so no changes should be made on that property.

@xg-wang xg-wang added the bug label Sep 11, 2019
@xg-wang xg-wang merged commit 3392739 into master Sep 12, 2019
@delete-merged-branch delete-merged-branch bot deleted the fastboot-request-bug branch September 12, 2019 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Using Request breaks in FastBoot
3 participants