Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ember-cli-typescript to 4.0.0. and update types to latest version #563

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update ember-cli-typescript to 4.0.0. and update types to latest version #563

wants to merge 2 commits into from

Conversation

kiwiupover
Copy link

No description provided.

@kiwiupover
Copy link
Author

kiwiupover commented Sep 9, 2020 •
edited

@rwjblue this PR updates ember-cli-typescript to 4.0.0

So that the PR adding embroider tests doesn't need to update ember-cli-typescript
#554

@kiwiupover kiwiupover mentioned this pull request Sep 9, 2020
Open
@kiwiupover
Copy link
Author

FYI @GCheung55 I have split out the ember-cli-typescript pr.

rwjblue
rwjblue reviewed Sep 22, 2020
View reviewed changes
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't the ember-cli-typescript bump be included here as well?

@xg-wang
Copy link
Member

xg-wang commented Jan 18, 2021

@kiwiupover have you tried to bump ember-cli-tpescript in this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kiwiupover @xg-wang @rwjblue