Add support to glimmer-wrapper for MU namespaces #215
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
resolver.resolve now takes a third argument `rawString` which is the
string used at the invocation site of the lookup. For example for:
```
{{ember-power-select::option}}
```
The lookup should be:
```
resolver.resolve('template:component/', null, 'ember-power-select::option')
``
And for a service example:
```
Ember.service.inject('auth-addon::main-service')
```
The lookup would be:
```
resolver.resolve('service', null, 'auth-addon::main-service')
```
Refs: #214
Refs: emberjs/ember.js#15350 (comment)
This was referenced Dec 12, 2017
mixonic
commented
Dec 16, 2017
| ); | ||
| }); | ||
|
|
||
| test('Can resolve a namespaced component template', function(assert) { |
There was a problem hiding this comment.
We need to add a test for looking up a component (not a template). Should basically be the same as the service test though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolver.resolve now takes a third argument
rawStringwhich is thestring used at the invocation site of the lookup. For example for:
The lookup should be:
And for a service example:
The lookup would be:
Refs: #214
Refs: emberjs/ember.js#15350 (comment)
TODO: