Update and test pnpm behavior so that we simulate a new user install #958
Conversation
Codecov Report
@@ Coverage Diff @@
## master #958 +/- ##
==========================================
- Coverage 94.54% 94.38% -0.17%
==========================================
Files 17 17
Lines 550 552 +2
==========================================
+ Hits 520 521 +1
- Misses 30 31 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
I wonder if we should make this new behavior have an opt-in or out? Users have the capability to override |
|
that's a good point 🤔 are you thinking it'd be like, a top-level config option like like, maybe: {
usePnpm: true,
adapterOptions: { // specific to each adapter, with their own defaults
keepLockfile: true, // default false
}
}idk |
|
@NullVoxPopuli I think that's a bit too close to Alternatively, I think there's some precedent in the repo for making our own flags that can be supplied in |
| expect(await fs.readFile('pnpm-lock.ember-try.yaml', 'utf-8')).to.equal( | ||
| 'originalYAML: true\n' | ||
| ); | ||
| expect(fs.existsSync('.node_modules.ember-try')).to.be.false; | ||
| }); | ||
|
|
||
| it('copies up the `pnpm-lock.yaml` file when pnpmUseLockfile is true (non-default)', async () => { |
There was a problem hiding this comment.
the inverse of this test is covered by the test above
| * @property {boolean} [useWorkspaces] | ||
| * @property {boolean} [useYarn] | ||
| * @property {boolean} [usePnpm] | ||
| * @property {boolean} [pnpmUseLockfile] default false - re-uses the lockfile, which would test minimum supported versions in the project. When false, we simulate a "new project install" |
There was a problem hiding this comment.
Do we also want to document this in the README?
|
Going to do a separate PR that uses this: |
Based on discussion here: https://discord.com/channels/480462759797063690/480501885837770763/1122582845873983529