Advance RFC #0907 "pnpm support" to Stage Ready for Release

[emberjs-rfcs-bot]

Advance #907 to the Ready For Release Stage

Summary

This pull request is advancing the RFC to the Ready For Release Stage.

• PR to Accepted Stage: Propose pnpm support #907

An FCP is required before merging this PR to advance.

Upon merging this PR, automation will open a draft PR for this RFC to move to the Released Stage.

Ready for Release Stage Description

This stage is complete when the implementation is complete according to plan outlined in the RFC, and is in harmony with any changes in Ember that have occurred since the RFC was first written. This includes any necessary learning materials. At this stage, features or deprecations may be available for use behind a feature flag, or with an optional package, etc.

For codebase changes, there are no open questions that are anticipated to require breaking changes; the Ember team is ready to commit to the stability of any interfaces exposed by the current implementation of the feature.

This stage should include a list of criteria for determining when the proposal can be considered Recommended after being Released.

An FCP is required to move into this stage.

Each Ember core team will be requested as a reviewer on the PR to move into this stage. A representative of each team adds a review. If a team does not respond to the request, and after the conclusion of the FCP, it is assumed that the release may proceed.

Checklist to move to Ready for Release

• Implementation is complete according to plan outlined in the RFC, with any adjustments noted in the RFC
• Any necessary learning materials have been updated
• The Ember team is ready to commit to the stability of any interfaces exposed by the current implementation of the feature. This is the go/no go decision for any feature flags, but the flags should only be turned on when moving to Released.
• Criteria for moving to the Recommended Stage has been filled out
• This PR has been converted from a draft to a regular PR and the Final Comment Period label has been added to start the FCP
• Each team has been added as a reviewer to the PR at the start of the FCP. Reviews are not required by the end of the FCP. This is a notification step.
  • Framework @emberjs/framework
  • Data @emberjs/ember-data-core
  • CLI @emberjs/cli
  • Learning @emberjs/learning-core
  • Typescript @emberjs/typescript-core
  • Steering @emberjs/steering

Criteria for moving to Recommended (required)

A set of criteria for moving this RFC to the Recommended Stage, following release:

1. Consider whether documentation should have ability to switch between npm/yarn/pnpm.

Track Implementation

• Support for --pnpm when generating a project in ember-cli #10287
• Support for pnpm when using ember install #10287
• Document and test support for pnpm in ember-try; remove experimental warning Remove warning about pnpm ember-cli/ember-try#956 Document pnpm options and behavior ember-cli/ember-try#957 Update and test pnpm behavior so that we simulate a new user install ember-cli/ember-try#958 Use pnpm's --no-lockfile ember-cli/ember-try#960
• Alias --skip-npm to --skip-install-deps
• Move pnpm action to an org or make it inline as part of the blueprint Determine preferable pnpm install action setup (should it move to an org we control? should we use pnpm's action? See comment here
• Update docs to indicate pnpm as an option
  • Update https://cli.emberjs.com/release/basic-use/ Add things about pnpm ember-learn/cli-guides#290
  • Update https://cli.emberjs.com/release/basic-use/cli-commands/ Add things about pnpm ember-learn/cli-guides#290
  • Update https://cli.emberjs.com/release/basic-use/assets-and-dependencies/ Add things about pnpm ember-learn/cli-guides#290
  • Update https://cli.emberjs.com/release/advanced-use/debugging Add things about pnpm ember-learn/cli-guides#290
  • Update https://cli.emberjs.com/release/writing-addons/intro-tutorial/ Add things about pnpm ember-learn/cli-guides#290
  • Update https://cli.emberjs.com/release/writing-addons/addon-blueprints/ Add things about pnpm ember-learn/cli-guides#290
  • Update https://cli.emberjs.com/release/advanced-use/cli-commands-reference/ Add things about pnpm ember-learn/cli-guides#290
  • Update https://guides.emberjs.com/release/addons-and-dependencies/ Mention the pnpm-lock.yaml ember-learn/guides-source#1944

Releasing checklist

• ember-cli (with pnpm flag on)
• ember-try
• Merge PRs to cli-guides
• Merge PRs to guides-source

[NullVoxPopuli]

Docs pr is here: ember-learn/cli-guides#290

[NullVoxPopuli]

ember-try:

• Remove warning about pnpm ember-cli/ember-try#956
• Document pnpm options and behavior ember-cli/ember-try#957

[NullVoxPopuli]

I think

Alias --skip-npm to --skip-install-deps

should be omitted from this list, because it's orthogonal to pnpm support.

We can still alias it, but I don't think it should be a blocker, since it's a pre-existing "weirdness"

[NullVoxPopuli]

PR for guides-source: ember-learn/guides-source#1944