Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Node 10, 12, 15, 17 #1318

Merged
merged 7 commits into from
Jul 19, 2022

Conversation

aggmoulik
Copy link
Contributor

@aggmoulik aggmoulik commented Oct 3, 2021

  • Drop Node 10 Support (end-of-life 2021-04)
  • Drop Node 12 support (end-of-life 2022-04-30)
  • Drop Node 15 Support (end-of-life 2021-06-01)
  • Drop Node 17 support (end-of-life 2022-06-01)
  • Remove flat() utility
  • Remove flatMap() utility

Part of v11 release (#1169).

Signed-off-by: Moulik Aggarwal <qwertymoulik@gmail.com>
@bmish bmish added the Breaking label Oct 3, 2021
@bmish
Copy link
Member

bmish commented Oct 3, 2021

We'll also want to drop Node 15 support in this PR.

This PR can eventually be part of the v11 release (#1169), but note that the v11 release is not urgent/imminent right now. Normally, we wait until we have additional recommended rules to enable before performing a major release (and we have no new recommended rules yets).

Signed-off-by: Moulik Aggarwal <qwertymoulik@gmail.com>
README.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
Co-authored-by: Bryan Mishkin <698306+bmish@users.noreply.github.com>
@aggmoulik aggmoulik requested a review from bmish November 22, 2021 04:22
@bmish bmish changed the title Drop Node 10 support Drop support for Node 10, 12 Jul 14, 2022
@bmish bmish changed the title Drop support for Node 10, 12 Drop support for Node 10, 15 Jul 14, 2022
@bmish bmish mentioned this pull request Jul 14, 2022
Copy link
Member

@bmish bmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also dropping Node 12/17 in this PR.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@bmish bmish changed the title Drop support for Node 10, 15 Drop support for Node 10, 12, 15, 17 Jul 15, 2022
Copy link
Member

@bmish bmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bmish bmish merged commit 746030b into ember-cli:master Jul 19, 2022
bmish added a commit to bmish/eslint-plugin-ember that referenced this pull request Jul 19, 2022
* master:
  breaking: add no-array-prototype-extensions as recommended rule (ember-cli#1517)
  breaking: remove base config (ember-cli#1518)
  breaking: stop exporting non-Ember utils (ember-cli#1513)
  breaking: update `avoid-leaking-state-in-ember-objects` rule to augment instead of replace default config (ember-cli#1512)
  breaking: strictly define Node API (ember-cli#1514)
  breaking: enable useOptionalChaining on no-get rule (ember-cli#1519)
  Drop support for Node 10, 12, 15, 17 (ember-cli#1318)
bmish added a commit that referenced this pull request Jul 19, 2022
* master:
  breaking: add no-array-prototype-extensions as recommended rule (#1517)
  breaking: remove base config (#1518)
  breaking: stop exporting non-Ember utils (#1513)
  breaking: update `avoid-leaking-state-in-ember-objects` rule to augment instead of replace default config (#1512)
  breaking: strictly define Node API (#1514)
  breaking: enable useOptionalChaining on no-get rule (#1519)
  Drop support for Node 10, 12, 15, 17 (#1318)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants