Stop exporting non-Ember utils #1513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
bmish
changed the title
lin-ll
approved these changes
Jul 15, 2022
bmish
added a commit
to bmish/eslint-plugin-ember
that referenced
this pull request
Jul 19, 2022
* master: breaking: add no-array-prototype-extensions as recommended rule (ember-cli#1517) breaking: remove base config (ember-cli#1518) breaking: stop exporting non-Ember utils (ember-cli#1513) breaking: update `avoid-leaking-state-in-ember-objects` rule to augment instead of replace default config (ember-cli#1512) breaking: strictly define Node API (ember-cli#1514) breaking: enable useOptionalChaining on no-get rule (ember-cli#1519) Drop support for Node 10, 12, 15, 17 (ember-cli#1318)
bmish
added a commit
that referenced
this pull request
Jul 19, 2022
* master: breaking: add no-array-prototype-extensions as recommended rule (#1517) breaking: remove base config (#1518) breaking: stop exporting non-Ember utils (#1513) breaking: update `avoid-leaking-state-in-ember-objects` rule to augment instead of replace default config (#1512) breaking: strictly define Node API (#1514) breaking: enable useOptionalChaining on no-get rule (#1519) Drop support for Node 10, 12, 15, 17 (#1318)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this github search, it doesn't look like anyone is importing anything of substance from our utils/utils.js utility file. These are all generic, non-Ember specific utils that are subject to change at any time and so it's best not to have anyone import/rely/depend on them.
If we hear that there's a need for any/some of these utils, we can consider individually-exporting them instead of exporting the entire file. Please file an issue if that is the case. For simple/trivial utils, it's probably best for anyone who uses them to just copy them into their own project.
Note that based on the above search, I did see a few more usages of our Ember utils, and those utils are specifically related to the purpose of eslint-plugin-ember, so we'll continue exporting those, but perhaps we should audit them at some point.
Related change:
Part of v11 release (#1169).