Enforce component lifecycle hook order #137
Conversation
|
@michalsnik @kevinkucharczyk what do you guys think of this? It should be basically the same implementation as the routes one, just different hooks. Would love to get this in, so we can enforce hook order in both routes and components 😄 |
There was a problem hiding this comment.
Hey @rwwagner90, thanks for putting your effort into this! It looks good to me and I agree with the proposed order :)
However I would also like to hear what @kevinkucharczyk or @Turbo87 might have to say about this proposal.
|
@michalsnik great, thanks for taking a look! I look forward to hearing what the other guys think 😃 |
|
@kevinkucharczyk @Turbo87 do you guys have any thoughts on this? Would love to get it merged in 😄 |
|
I've stopped using the tl;dr I don't use those rules at the moment so I'm fine with whatever you decide. |
|
@Turbo87 I would be glad to help try to implement a |
|
@michalsnik since @Turbo87 is okay with this, and it's been approved, can we merge? |
|
@michalsnik would it be possible to get a release with these changes please? I also looked at the releases on here and it looks like 4.3.0 was the last officially tagged "release" and 4.4 and 4.5 were just tags pushed up. Wanted to make you aware of that in case we want them to show as official releases on GitHub. |
As a followup to my previous route hook order PR (#124) I wanted to get one started for components, and models will be next after this 😄
I’m enforcing that component hooks be called, more or less, in execution order. There is some weirdness to consider with certain hooks executed on both initial render and rerender, but I believe this order makes sense.