Avoid some errors that break eslint-plugin-ember for gts #1667
Conversation
|
I like the branch name 🙃 |
| @@ -105,7 +105,8 @@ function mapRange(messages, filename) { | |||
|
|
|||
| return flattened.map((message) => { | |||
| const line = lines[message.line - 1]; | |||
| const token = line.slice(message.column - 1, message.endColumn - 1); | |||
| // `line` can be undefined here sometimes. I suspect maybe `message.line` is incorrect above. | |||
There was a problem hiding this comment.
I wonder if this is due to file-wide messages, or maybe there is another property to use?
Anywho, happy to see this more resilient
There was a problem hiding this comment.
I think we need to figure out whether this is a legitimate scenario. I would rather we fail fast on unexpected/invalid input than hide potential problems. And of course, if it is a legitimate scenario, need to have tests for it.
There was a problem hiding this comment.
FWIW line numbers are way off for most of my error messages (usually 0:0). The fixes in this branch only get things running.
There was a problem hiding this comment.
turns out this is a legit scenario, because folks can cause parse errors, which occur on the whole file and don't have a line/column/etc
| </template> | ||
| `, | ||
| }, | ||
| // This test fails on master with "Preprocessing error: Cannot overwrite a zero-length range – use appendLeft or prependRight instead" |
There was a problem hiding this comment.
Ah ok, so we need to figure this out, still 🤔
There was a problem hiding this comment.
@NullVoxPopuli @gitKrystan we need to get master unblocked. Can one of you submit a PR to fix or disable this test? I can't accept the current PR as-is because it has untested changes in it. It may be best to fix the test on master first and then work on the bug fix afterward.
FAIL tests/lib/rules-preprocessor/gjs-gts-processor-test.js
● template-vars › valid ›
const Foo = <template>hi</template>
<template>
<Foo />
</template>
expect(received).toBe(expected) // Object.is equality
Expected: ""
Received: "Preprocessing error: Cannot overwrite a zero-length range – use appendLeft or prependRight instead"
There was a problem hiding this comment.
I'm not sure I have enough context to get this to a mergeable state, but I'd be happy to pair with someone on it.
There was a problem hiding this comment.
One of these commits is causing the error: ember-template-imports/ember-template-imports@v3.1.1...v3.1.2
I'm about to put up a PR fixing the test
There was a problem hiding this comment.
@bmish because this feature is new, I'd be fine with leaving the test commented out for now -- there are a couple things with the position mapping in general that might need more in-depth looking, I think
There was a problem hiding this comment.
Skipping the test in a separate PR is fine as a temporary solution since it's blocking master.
|
Note that this change was reverted: |
I needed these changes to get eslint-plugin-ember running on my gts files.