Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

alias-model-in-controller: allow nested properties #80

Merged
merged 1 commit into from
Jun 7, 2017

Conversation

buschtoens
Copy link
Contributor

@buschtoens buschtoens commented Jun 6, 2017

Fixes #79.

You can now do this:

 const { reads } = Ember.computed;
 export default Ember.Controller.extend({
   people: reads('model.people'),
   pets:   reads('model.pets')
 });

Copy link
Member

@michalsnik michalsnik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

@michalsnik michalsnik merged commit 691aa24 into ember-cli:master Jun 7, 2017
@michalsnik
Copy link
Member

Thanks for your contribution @buschtoens! I'll try to release it tomorrow :)

@catz
Copy link

catz commented Jun 20, 2017

Nice change! Waiting for the new release.

@jguitar
Copy link

jguitar commented Jun 23, 2017

👍 And also waiting for the new release

@michalsnik
Copy link
Member

michalsnik commented Jun 26, 2017

@jguitar @catz @buschtoens Sorry for such late action with this one, here's the new release: https://github.com/netguru/eslint-plugin-ember/releases/tag/v3.5.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants