Check object extensibility before adding default property. #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The checks added previously were checking for `Object.isFrozen`, but that only covers one scenario (`Object.freeze`) and it is still possible to make an object non-extensible without freezing it. This adds tests for frozen objects (previously passing) and a new test for `Object.seal`'ed objects (which was failing prior to this change).
This was referenced Mar 5, 2017
|
Seems good. I think I'm running into to this on Kris build rework branch. |
|
Yes, it is an issue for anything (in babel@6) that exports something that is either frozen or sealed. The most common case is when you |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The checks added previously were checking for
Object.isFrozen, but that only covers one scenario (Object.freeze) and it is still possible to make an objectnon-extensible without freezing it.
This adds tests for frozen objects (previously passing) and a new test for
Object.seal'ed objects (which was failing prior to this change).