Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up helpers code #70

Merged
merged 3 commits into from
Mar 15, 2018
Merged

Clean up helpers code #70

merged 3 commits into from
Mar 15, 2018

Conversation

bantic
Copy link
Collaborator

@bantic bantic commented Mar 14, 2018

This follows on #69 to clean it up a little bit.

  • Add "import { helper } from '@ember/component/helper" and an export to all the helpers in fixtures inputs
  • Update the corresponding expectation in the fixtures outputs
  • Add common-tags as a devDep to allow using stripIndents
  • Extract the helper codemod code to a separate file
  • Modify lib/models/file-info.js to apply the helper codemod to the output of the importDeclarationsTransform

@bantic
add common-tags dep
d00ed22
@bantic
Make all test fixtures for helpers include imports
079e447 
This makes the helpers a little more like what might be encountered
in reality.

This uses the `stripIndents` tag function to make it easier to do
multi-line files.
@bantic
Extract helper-fixing codemod to a separate file
0e3e56c
@rwjblue
Copy link
Member

rwjblue commented Mar 15, 2018

Thank you!!!

@rwjblue rwjblue merged commit 0b50166 into ember-codemods:master Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bantic @rwjblue