Add failing test cases for ES6 classes #61
Conversation
|
Are there any plans to support es6 classes soon? |
|
I think ES6 class support is nearly there, but they don't make sense yet, as the decorator proposal is still in flux. Babel 6 even dropped decorator support: http://babeljs.io/docs/plugins/transform-decorators/. |
|
Interesting. @topaxi do you see any future headaches by using this addon now? |
|
@Ramblurr I definitely see future hazards if you are using this now, first, we don't know when decorators will be standardized, second, we don't know what changes will be made until then. As far as I know, in the current spec, the order in which the decorators are executed was reversed, which might be a problem sooner than later (I'm not 100% sure on this one though @rwjblue might know more here). |
|
@offirgolan - Mind rebasing here? I believe these tests will pass... |
| /* jshint ignore:start */ | ||
| @computed('first', 'last') | ||
| /* jshint ignore:end */ | ||
| get fullName() { |
There was a problem hiding this comment.
We explicitly throw on this:
ember-decorators does not support using getters and setters
I think mostly because we haven't thought it through just yet.
Thoughts @stefanpenner / @pzuraq?
There was a problem hiding this comment.
I think we can do this, we just have to figure out how to reach into existing descriptors in cases where both a getter and setter are used. I'll try to find some time later today to spike it out.
There was a problem hiding this comment.
Ya, I think it makes sense for @computed (for example), but not all of them. e.g. @observer with a getter or setter is pretty WAT...
There was a problem hiding this comment.
Ah, yeah definitely, this should probably only be for @computed (can't think of another one where it would make sense tbh)
No description provided.