Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform tests to 'setup-test' syntax #90

Merged

Conversation

evanfarina
Copy link
Contributor

In addition to running the ember-qunit-codemode a few changes were necessary:

  1. Add autoboot=false to environment.js. This ensures that duplicate apps are not created when running tests. I searched through a few others apps and read through a handful of issues on github before coming to the conclusion that this was an accepted best practice. If anyone feels that there is a more sustainable to solution to multiple container divs being created when running tests please let me know.
  2. With the new syntax instance-initializers will now execute. This impacts how a handful of tests should be setup since manifests will now exist prior to each test running. Some tests had to be updated to look for different error messages being thrown while other tests required a deletion of setup code that was being used to generate manifests.
  3. Added includePolyfill to ember-cli-build due to a regeneratorRuntime is not defined error being thrown.
  4. Manually updated how the test runner is setup in tests/test-helper.js

config/environment.js Outdated Show resolved Hide resolved
ember-cli-build.js Outdated Show resolved Hide resolved
@evanfarina
Copy link
Contributor Author

evanfarina commented Jan 9, 2020

@rwjblue I've spent the last day digging into the travis failures and what I've found is this:

  • We're using a very old version of ember-cli-sauce
  • We're using an old version of "sauce connect" -- this likely needs to be configured in the repo's settings (or the travis.yml file if you'd prefer)
  • Updating to the latest version of ember-cli-sauce shows the same errors (tested locally)
  • ember-cli-sauce has not been updated in over a year and seems to have problems with recent versions of ember-cli-qunit

.travis.yml Outdated Show resolved Hide resolved
@rwjblue
Copy link
Member

rwjblue commented Jan 16, 2020

Mind rebasing to get the CI fixes?

@evanfarina
Copy link
Contributor Author

Mind rebasing to get the CI fixes?

Rebased. Had to make some adjustments to keep travis (saucie) happy.

@rwjblue rwjblue merged commit be46f96 into ember-engines:master Jan 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants