POC: Don’t accidentally re-include the compact reexport plugin more then once #596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I noticed this was causing us to mutate the share plugin state, resulting in babel-plugin-compact-reexports being included 1 per apps engine... |
rwjblue
approved these changes
Oct 3, 2018
gabrielcsapo
reviewed
Oct 3, 2018
lib/engine-addon.js
Outdated
| } | ||
|
|
||
| this.options.babel.plugins.push(require.resolve('babel-plugin-compact-reexports')); | ||
| if (this.options.babel.plugins.indexOf(BABEL_COMPACT_REEXPORTS_PLUGIN)) { |
There was a problem hiding this comment.
Agree, especially since the original code was wrong (didn’t have > -1)...
stefanpenner
force-pushed
the
fix-duplicate-babel-plugin-issue
branch
from
9f50617
to
a6749e6
Compare
stefanpenner
force-pushed
the
fix-duplicate-babel-plugin-issue
branch
from
a6749e6
to
d970f6f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc @rwjblue