Fix usage of dependencySatisfies with a peerDependency #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Similar fix in |
SergeAstapov
approved these changes
Jan 17, 2022
|
How can we get this merged and released? This is blocking a lot of my pipelines.. |
|
I approved the CI run, but it seems that it got cancelled; I'm restarting it |
|
@rwjblue probably it cancels 3.x tests because release/beta get fail too fast at build time because of ember-auto-import v2/webpack miss which is another level of effort |
packages/ember-engines/package.json
Outdated
| @@ -86,7 +86,7 @@ | |||
| "ember-addon" | |||
| ], | |||
| "dependencies": { | |||
| "@embroider/macros": "^0.43.5", | |||
| "@embroider/macros": "^0.50.2", | |||
There was a problem hiding this comment.
@anehx @embroider/macros is now 1.0.0 so we should be able to do just "@embroider/macros": "^1.0.0"
anehx
force-pushed
the
fix-dependency-satisfies
branch
from
565e2f2
to
c08f765
Compare
SergeAstapov
approved these changes
Jan 20, 2022
|
This is a major issue for me, can I do anything to help getting this released? |
1 task
villander
reviewed
Jan 30, 2022
Merged
Merged
This package uses `dependencySatisfies` of `@embroider/macros` which is only reliable if a `peerDependency` for the package exists. If not, the macro checks for a dependency in the `ember-engines` package when a monorepo structure is used. This behaviour happens since embroider v0.50.1 which includes an important fix for monorepos: embroider-build/embroider#1070
anehx
force-pushed
the
fix-dependency-satisfies
branch
from
c08f765
to
35fd62d
Compare
rwjblue
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This package uses
dependencySatisfiesof@embroider/macroswhich isonly reliable if a
peerDependencyfor the package exists. If not, themacro checks for a dependency in the
ember-enginespackage when amonorepo structure is used. This behaviour happens since embroider
v0.50.1 which includes an important fix for monorepos:
embroider-build/embroider#1070