Fix Ember.merge deprecations #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks again @trentmwillis! |
|
FYI - This deprecation has been removed from canary/beta/release and will be released as 2.5.1 sometime Monday. |
|
@rwjblue interesting, looking at the PR to turn it off, sounds like it will still be turned back on in a future release though, correct? The ecosystem just isn't ready for it to be deprecated right now. |
|
@trentmwillis - Yep, I was definitely not suggesting that this PR was invalid or anything. I'm mostly just pointing out, that many many things are spewing this deprecation at the moment so we decided to disable. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing #79.