Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Ember Data FastBoot support to Ember Data itself #588

Open
tchak opened this issue Mar 17, 2018 · 2 comments
Open

Move Ember Data FastBoot support to Ember Data itself #588

tchak opened this issue Mar 17, 2018 · 2 comments

Comments

@tchak
Copy link

tchak commented Mar 17, 2018

We are adding direct support for FastBoot in Ember Data.

emberjs/data#5385

We will have two paths: jQuery.ajax which will require najax and a new, opt-in ember-fetch backend which have built in FastBoot support and do not require najax.

I don't think we can/should drop MonkeyPatch™ from ember-cli-fastboot right away because of support for older ED. But I am interested to hear what would be an acceptable time frame for doing it (@rwjblue)?

@kratiahuja
Copy link
Contributor

I am not sure what the motivation is behind adding the patching in ember-data itself. It should be agnostic to all this. Please see my reasoning on your PR.

@rwjblue
Copy link
Member

rwjblue commented Mar 19, 2018

Ultimately it is odd that this addon is coupled in any way to ember-data. Ideally, fastboot provides capabilities that are used by other addons to get their jobs done. The current path (encoding non-fastboot addon logic in ember-cli-fastboot) is not scalable...

The ember-data team is working to move away from the $.ajax style of request (towards using ember-fetch), and having ember-data “own” this particular aspect makes it easier for it to massage the migration story.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants