Update using ember-cli-update and drop support for Node 10 #834
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snewcomer
reviewed
Jun 2, 2021
snewcomer
approved these changes
Jun 4, 2021
|
Thanks for the note @snewcomer 馃槀 but I don't entirely agree that this looks like great work 馃槀 The thing is I don't know that putting a resolution in our package.json will "fix" the issue, because anyone downstream will still have this issue. I briefly discussed this with @Turbo87 in discord the other day and we had some ideas on how to proceed: https://discord.com/channels/480462759797063690/485861149821239298/850047640816582767 I would love to know your thoughts, It's a shame I couldn't join the meeting yesterday because I would have loved to discuss this. |
https://nodejs.org/en/about/releases/ # Conflicts: # packages/ember-cli-fastboot/package.json
mansona
changed the title
sumitd94
approved these changes
Jul 9, 2021
| @@ -21,6 +21,13 @@ | |||
| {{content-for "body"}} | |||
| {{content-for "test-body"}} | |||
|
|
|||
| <div id="qunit"></div> | |||
There was a problem hiding this comment.
NIT: we can self enclose the tag here
<div id="quint" />| <div id="qunit"></div> | ||
| <div id="qunit-fixture"> | ||
| <div id="ember-testing-container"> | ||
| <div id="ember-testing"></div> |
mansona
changed the title
xg-wang
approved these changes
Jul 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So this PR has been a bit of a saga 馃檲
Essentially I have been trying to get #824 working (so that we can add node 16 to our test suite) and I have been having the world of trouble.
To make a long story very short: we had a problem with a sub-sub-sub-dependency of ember-cli-babel@6, workerpool. The version that we had in our sub-sub-sub-dependencies was very very old and had a bug in it that broke Node 16 that was fixed in the latest version.
My first attempt to fix this was to try and update the version of workerpool that we used in our old ember-cli-fastboot and potentially release a patch version of that: babel/broccoli-babel-transpiler#203 but @rwjblue rightly said that this caused odd semver concerns.
in that conversation @stefanpenner said that if we could patch the old version of workerpool then we could release a patch of that old version, so I did 馃帀 josdejong/workerpool#309
Now that workerpool@2.3.4 has been released our problem with Node 16 that was failing the tests has gone away 馃帀
Todo