fix: removes slow leak by emptying cache for source maps #895
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Brenden Palmer <brendenpalmer@gmail.com> Co-authored-by: Robert Jackson <rjackson@linkedin.com>
rwjblue
approved these changes
Jun 14, 2022
rwjblue
reviewed
Jun 14, 2022
Comment on lines
-4
to
-6
| Error.prepareStackTrace = function prepareStackTrace(error, stack) { | ||
| return error + stack.map(frame => '\n at ' + sourceMapSupport.wrapCallSite(frame)).join(''); | ||
| }; |
There was a problem hiding this comment.
Note: this is removed because source-map-support never uses the pre-existing Error.prepareStackTrace value (it always clobbers).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A faster fix for the slow memory leak explained in #894, but without depending on the vm to have source maps knowledge which is currently a bug.