Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fastboot deprecation #29

Closed
oskarrough opened this issue Jun 3, 2017 · 8 comments
Closed

Fastboot deprecation #29

oskarrough opened this issue Jun 3, 2017 · 8 comments

Comments

@oskarrough
Copy link

Hi, seeing this with ember-cli-fastboot 1.0.0 rc.2 and ember-cli-head 0.2.2.

DEPRECATION: Having fastboot specific code in app directory of 
/Users/xxx/Sites/xxx/node_modules/ember-cli-head is deprecated. Please move it to fastboot/app directory.

I think it is this https://gist.github.com/kratiahuja/d22de0fb1660cf0ef58f07a6bcbf1a1c#addon-containing-fastboot-based-initializers-as-appinstance-initializersfastbootjs

Also see ember-fastboot/ember-cli-fastboot#387 (comment)

@kratiahuja
Copy link

This is already fixed with : #21 Can you provide a reproduction?

@kratiahuja
Copy link

Deprecation path seems wrong too: /Users/xxx/Sites/xxx/node_modules/ember-cli-head

@oskarrough
Copy link
Author

The xxx part is my username. Or is the path otherwise wrong?

Here's a reproduction: https://github.com/oskarrough/fastboot-head-test. Thank you!

@kratiahuja
Copy link

The path is wrong.

@kratiahuja
Copy link

That is just a warning since we are doing the auto migration for you. Once addons and fastboot drop support for pre fastboot 1.0, they can address this deprecation.

Your app would still work.

@oskarrough
Copy link
Author

It does work :) I just wanted to help fix the deprecation.

@cibernox
Copy link
Contributor

cibernox commented Jun 6, 2017

@oskarrough I believe I closed this in #32

@rwjblue rwjblue closed this as completed Jun 6, 2017
@oskarrough
Copy link
Author

@cibernox confirmed. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants