Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

no longer depend on mysterious fast boot flag #30

Conversation

stefanpenner
Copy link

No description provided.

index.js Outdated
if (!process.env.FASTBOOT_NEW_BUILD) {
let fastboot = this.project.findAddonByName('ember-cli-fastboot');

if (fastboot && semver.gte(fastboot.pkg.version, '1.0.0-rc.1')) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this should be lte

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, didn't does't the negate on line 13.

@cibernox
Copy link
Contributor

cibernox commented Jun 6, 2017

@stefanpenner I believe I closed this with #32

@rwjblue rwjblue closed this Jun 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants