New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UnrecognizedURLError should send 404 #15

Closed

kitsunde wants to merge 1 commit into ember-fastboot:master from kitsunde:patch-1

Contributor

kitsunde commented Dec 1, 2016

It's already giving 500, what we need to do is specifically check for UnrecognizedURLError and send out 404.


          UnrecognizedURLError should send 404

b2af3ec

kitsunde mentioned this pull request

UnrecognizedURLError gives a 500 ember-fastboot/fastboot-app-server#37

Open

arjansingh suggested changes

View reviewed changes

src/index.js

@@ @@ -58,8 +58,8 @@ function fastbootExpressMiddleware(distPath, options) { @@
                   }
                   function failure(error) {
-                    if (error.name !== "UnrecognizedURLError") {
-                      res.status(500);
+                    if (error.name === "UnrecognizedURLError") {

Contributor

arjansingh Dec 13, 2016

We'd need an if/else here to set either 404 or 500. Also tests please.

rwjblue mentioned this pull request

Ensure 404's receive the proper response code. #21

Merged

rwjblue closed this in #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment