Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for Node 6, 9, and 11. #225

Merged

Conversation

kiwiupover
Copy link
Member

We are testing against node 8, 10, 12 and stable
https://github.com/ember-fastboot/fastboot/blob/master/.travis.yml#L3-L6

Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good to me, but this will need to be another major version bump.

@rwjblue
Copy link
Member

rwjblue commented Jul 12, 2019

@kiwiupover The .travis.yml link you pasted above does include Node 6 (and that is what is failing in CI on this PR). I think you'll need to remove it.

@kiwiupover
Copy link
Member Author

@rwjblued does the node version - "stable" test against Node 13 when it is released of only Node 14, 16 and so on

@rwjblue rwjblue merged commit a0b5ea2 into ember-fastboot:master Jul 26, 2019
@kiwiupover kiwiupover deleted the drop-node-6-add-new-node-versions branch July 26, 2019 16:15
@rwjblue rwjblue changed the title Update node engines to match node versions we are testing against Drop support for Node 6, 9, and 11. Jul 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants