Restore allowing fallback require from working directory #227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rwjblue @kratiahuja @bobisjan Can you review? |
snewcomer
reviewed
Jul 23, 2019
- For deployed app, dist/node_modules is required - For development mode in ember-cli-fastboot, require can fallback to lookup working directory node_modules
rwjblue
reviewed
Jul 24, 2019
node API doc: https://nodejs.org/docs/latest-v6.x/api/modules.html#modules_file_modules Co-Authored-By: Robert Jackson <me@rwjblue.com>
rwjblue
approved these changes
Jul 24, 2019
|
@rwjblue @kratiahuja should this be released as a bug fix bump? |
|
bump on getting this merged 😄 🙏 |
|
fastboot v2.0.2 is release with this fix only. Will release v3.0.0 later this week in order to ensure if there are other commits, they can go in. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the behavior for legacy whitelist.
Fix #221 ember-fastboot/ember-cli-fastboot#711