Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore result finalization in resilient mode #277

Merged

Conversation

bobisjan
Copy link
Contributor

Previous version 2.x always finalised the result https://github.com/ember-fastboot/fastboot/blob/v2.0.3/src/ember-app.js#L363.

This PR restores that behaviour, which should unlock ember-fastboot/fastboot-express-middleware#70.

Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @bobisjan!

@rwjblue rwjblue added the bug label Oct 23, 2020
@rwjblue rwjblue merged commit 9b69cf5 into ember-fastboot:master Oct 23, 2020
@bobisjan bobisjan deleted the resilient-result-finalization branch October 23, 2020 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants