-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only Use Contextify When Required #9
Conversation
Thanks @jmurphyau, can you move the host change into a separate PR? There are still a few commented out lines that should be cleaned up as well. Lastly, please use the style |
7677be9
to
9ecab98
Compare
@tomdale should look a bit better now |
Also, just an FYI - that plugin you mentioned about installing dependancies based on node version.. What it did was install a version of npm (which could be (and in my case was) a different version to the users current npm) as a dependancy and then programatically install the dependancies.. The tried this and I had two issues with it:
So instead of using that I've gone with a script that checks the |
Awesome! Thank you for all the hard work. I'm very excited about this change. |
Only Use Contextify When Required
@jmurphyau I had to revert this because it causes npm installs of this package to fail if it's not a legacy VM. |
really? hmm thats odd.. I use the latest node/npm - which fall into the category you mention - and it appeared to work fine for me.. Do you have any example of the error that appears |
Skip unnecessary buffers
I didn't realise my other PR was closed.. It seems they close themselves when the branch is exactly the same as the branch you're doing the PR against..
This PR adds the host option and uses/installs contextify only when it's needed (< node 0.10.x)