Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Build Targets page to CLI guides #163

Merged
merged 4 commits into from
Apr 30, 2020
Merged

Conversation

mehulkar
Copy link
Contributor

@mehulkar mehulkar commented Apr 2, 2020

This is copied from https://guides.emberjs.com/release/configuring-ember/build-targets/

Closes #159.

Once merged, the Ember Guides should link to this page. That PR is here: ember-learn/guides-source#1417

guides/advanced-use/build-targets.md Outdated Show resolved Hide resolved
guides/advanced-use/build-targets.md Outdated Show resolved Hide resolved
Ember CLI by default uses [Babel.js](https://babeljs.io/) to allow you to use tomorrow's JavaScript, today.

It will ensure that you can use the newest features in the language and know that they will be transformed to JavaScript that can run in every browser you support.
That usually means generating ES5-compatible code that can work on any modern browser, back to Internet Explorer 11.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
That usually means generating ES5-compatible code that can work on any modern browser, back to Internet Explorer 11.
That usually means generating ES5-compatible code that can work on any legacy browser, back to Internet Explorer 11.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think "modern" here is more correct, but I can see how it's confusing. How about just removing this sentence? The previous sentence ends "every browser you support", and I think that should be enough. I don't see a need to call out IE11 specifically

mehulkar and others added 2 commits April 21, 2020 06:42
Co-Authored-By: Rajasegar Chandran <rajasegar.c@gmail.com>
Co-Authored-By: Rajasegar Chandran <rajasegar.c@gmail.com>
@jenweber
Copy link
Contributor

The status of this PR is that the learning team wasn't sure about what should happen on the Ember Guides side, or where the line should be drawn between Ember Guides or CLI guides. We are open to suggestions! Comments/advice welcome on the meta question issue here: #168

@jenweber
Copy link
Contributor

jenweber commented Apr 30, 2020

We discussed this PR in today's learning team meeting and want to move forward with it!

In order to move content out of the Ember Guides and into the CLI guides, the "old" page still needs to have some rich content that points people towards the learning resources. It should not be a "dead" page, so that the guides do not become like a pruned tree.

more details here #168 (comment)

I will update ember-learn/guides-source#1377 with the general to-do list for getting these 2 PRs merged. Both sides should be ready to merge before we merge either of them.

Copy link
Contributor

@jenweber jenweber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this work!

@jenweber jenweber merged commit c3791a0 into ember-learn:master Apr 30, 2020
@mehulkar mehulkar deleted the mk/159 branch April 30, 2020 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build targets page should be moved to CLI guides
3 participants