Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change travis.yml to use Node 8 like the ember.js guides #76

Merged
merged 1 commit into from Dec 6, 2018
Merged

Change travis.yml to use Node 8 like the ember.js guides #76

merged 1 commit into from Dec 6, 2018

Conversation

jenweber
Copy link
Contributor

@jenweber jenweber commented Dec 6, 2018

As noded in #61, we should upgrade to Node 8. This matches what is done in the main guides so I expect it to work here too for our CI.

@jenweber
Copy link
Contributor Author

jenweber commented Dec 6, 2018

cc @maxwondercorn

@jenweber jenweber requested a review from mansona December 6, 2018 04:54
@jenweber jenweber mentioned this pull request Dec 6, 2018
Open
mansona
mansona approved these changes Dec 6, 2018
View reviewed changes
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yay faster node 🎉

@mansona mansona merged commit 0e50a4e into master Dec 6, 2018
@delete-merged-branch delete-merged-branch bot deleted the travis-node-version branch December 6, 2018 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mansona mansona mansona approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jenweber @mansona