Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Filterable deprecations #361

Draft
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

NullVoxPopuli
Copy link
Contributor

@NullVoxPopuli NullVoxPopuli commented Jun 4, 2019

Continuation of: #191

  • rebased
  • fix rebase mistakes

stuff doesn't work, don't know why 🤷‍♂️
image
image

@MelSumner
Copy link
Member

@NullVoxPopuli @mansona any thoughts on this one?

@NullVoxPopuli
Copy link
Contributor Author

I think filtering is useful, but I don't know how much of this implementation is salvageable. especially given that there are errors that idk if they are worth investigating. Maybe things from this attempt could be pulled in to a fresh branch though

@mansona mansona changed the title Filterable deprecations WIP: Filterable deprecations Jul 15, 2019
@jaredgalanis
Copy link
Member

jaredgalanis commented Jul 17, 2019

I think filtering is useful, but I don't know how much of this implementation is salvageable. especially given that there are errors that idk if they are worth investigating. Maybe things from this attempt could be pulled in to a fresh branch though

@NullVoxPopuli the errors seem to be coming from yarn install. When I blow away node_modules and npm install I do not get the errors (I was also getting them with yarn).

Are you interested in picking this back up again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants