Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parent link to modules #139

Merged
merged 1 commit into from
Feb 27, 2017

Conversation

esantelises
Copy link
Contributor

Addresses #104, display submodule parent.

Depends on ember-learn/ember-jsonapi-docs#20

image

@Gaurav0
Copy link
Contributor

Gaurav0 commented Feb 26, 2017

Can you look at the test failure?

@esantelises
Copy link
Contributor Author

@Gaurav0 since acceptance tests depends on some data to be loaded for some versions like 1.0.0, my
guess is parent attribute is still missing on CI data not sure if after ember-learn/ember-jsonapi-docs#20 is merged i would just need to re-run the build or if need to update the data somewhere else? (all test are passing locally)

@toddjordan
Copy link
Contributor

Fix works on my local env as well. I've merged the jsonapi-doc side of the fix, se we need to deploy/refresh the cloudant db.

Fix LGTM. Thanks!

@Gaurav0 Gaurav0 merged commit 3b9d4e5 into ember-learn:master Feb 27, 2017
@esantelises esantelises deleted the add-parent-link-to-modules branch February 27, 2017 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants