Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a description for Classic subsection for Element Modifiers #53

Merged
merged 1 commit into from Aug 5, 2020

Conversation

ijlee2
Copy link
Member

@ijlee2 ijlee2 commented Jul 31, 2020

Description

This PR addresses and can close #45.

I opted for adding a paragraph (i.e. a translation key) that explains that @ember/render-modifiers can still be used in classic apps as long as the Ember version is 2.18 or higher.

screenshot

Notes

The alternative approach that I had thought of was to update the <GuideSection::Subsection> component template to conditionally render a does-not-apply message. I thought adding the conditional logic,

{{#if (or @subsection.classicFiles @subsection.classicDescriptionKey)}}
  {{!-- Show classicFiles or classicDescriptionKey --}}
{{else}}
  {{!-- Show does-not-apply message --}}
{{/lf}}

one for Classic and yet another for Octane, might cause the template to be messy now or later.

@ijlee2 ijlee2 requested a review from a team July 31, 2020 14:26
Copy link
Member

@amyrlam amyrlam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good improvement!

@ijlee2 ijlee2 merged commit c6262c8 into master Aug 5, 2020
@ijlee2 ijlee2 deleted the address-empty-area-in-element-modifiers branch August 5, 2020 03:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug - The "Classic" example for Element Modifiers is missing
2 participants