Added a description for Classic subsection for Element Modifiers #53
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses and can close #45.
I opted for adding a paragraph (i.e. a translation key) that explains that
@ember/render-modifiers
can still be used in classic apps as long as the Ember version is 2.18 or higher.Notes
The alternative approach that I had thought of was to update the
<GuideSection::Subsection>
component template to conditionally render a does-not-apply message. I thought adding the conditional logic,one for Classic and yet another for Octane, might cause the template to be messy now or later.